Bug 234045 - Move matchSystemFontUse to SystemFontDatabase
Summary: Move matchSystemFontUse to SystemFontDatabase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks: 233488
  Show dependency tree / graph
 
Reported: 2021-12-08 16:59 PST by Cameron McCormack (:heycam)
Modified: 2022-07-20 21:45 PDT (History)
6 users (show)

See Also:

Attachments
Patch (9.65 KB, patch)
2021-12-08 17:00 PST, Cameron McCormack (:heycam) 		mmaxfield: review+
Details | Formatted Diff | Diff
Patch (9.51 KB, patch)
2022-07-20 14:40 PDT, Matt Woodrow 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-12-08 16:59:36 PST 
Move matchSystemFontUse to SystemFontDatabase
Comment 1 Cameron McCormack (:heycam) 2021-12-08 17:00:40 PST 
Created attachment 446460 [details]
Patch
Comment 2 Myles C. Maxfield 2021-12-10 15:01:02 PST 
Comment on attachment 446460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446460&action=review

> Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.h:128
> +    Vector<AtomString> m_textStyles;

Thinking about this, I think you're right, this is probably better.
Comment 3 Radar WebKit Bug Importer 2021-12-15 17:00:31 PST 
<rdar://problem/86550072>
Comment 4 Matt Woodrow 2022-07-20 14:40:27 PDT 
Created attachment 461055 [details]
Patch
Comment 5 EWS 2022-07-20 21:45:03 PDT 
Committed 252682@main (3f53693343ca): <https://commits.webkit.org/252682@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461055 [details].