Bug 234035 - [LFC][IFC] Stop including inline box start/end inline items in the visual reordering unless they are completely empty
Summary: [LFC][IFC] Stop including inline box start/end inline items in the visual reo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-08 14:32 PST by zalan
Modified: 2021-12-09 15:13 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.43 KB, patch)
2021-12-08 15:10 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (4.44 KB, patch)
2021-12-09 13:39 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-12-08 14:32:10 PST 
non-empty inline box visual order should all be driven by its content.
Comment 1 zalan 2021-12-08 15:10:40 PST 
Created attachment 446435 [details]
Patch
Comment 2 Antti Koivisto 2021-12-09 08:31:28 PST 
Comment on attachment 446435 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446435&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:324
> +        enum class InlineBoxHasContent { No, Yes };

: bool
Comment 3 zalan 2021-12-09 13:39:42 PST 
Created attachment 446600 [details]
Patch
Comment 4 EWS 2021-12-09 15:12:55 PST 
Committed r286807 (245046@main): <https://commits.webkit.org/245046@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446600 [details].
Comment 5 Radar WebKit Bug Importer 2021-12-09 15:13:24 PST 
<rdar://problem/86293395>