Bug 234007 - [libpas] Fix up missing header includes and build guards in unit tests
Summary: [libpas] Fix up missing header includes and build guards in unit tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-08 07:32 PST by Zan Dobersek
Modified: 2021-12-09 03:25 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.34 KB, patch)
2021-12-08 07:32 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (7.26 KB, patch)
2021-12-09 00:45 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2021-12-08 07:32:41 PST 
[libpas] Fix up missing header includes and build guards in unit tests
Comment 1 Zan Dobersek 2021-12-08 07:32:56 PST 
Created attachment 446363 [details]
Patch
Comment 2 Yusuke Suzuki 2021-12-08 11:19:22 PST 
Comment on attachment 446363 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446363&action=review

> Source/bmalloc/libpas/src/test/IsoHeapChaosTests.cpp:622
> +#if PAS_OS(DARWIN)
>              for (pthread_t thread : runningThreads) {
>                  kern_return_t result = thread_suspend(pthread_mach_thread_np(thread));
>                  PAS_ASSERT(result == KERN_SUCCESS);
>              }
> +#endif

If we cannot suspend and resume threads, then this test is broken. So you need to disable this test for that platforms.
Comment 3 Zan Dobersek 2021-12-09 00:45:15 PST 
Created attachment 446506 [details]
Patch

Disabled enumerator tests in IsoHeapChaosTests for Linux, due to the missing thread suspension/resuming. Also adjusted inclusions so that they follow the existing order.
Comment 4 EWS 2021-12-09 03:24:43 PST 
Committed r286773 (245014@main): <https://commits.webkit.org/245014@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446506 [details].
Comment 5 Radar WebKit Bug Importer 2021-12-09 03:25:23 PST 
<rdar://problem/86263339>