RESOLVED FIXED Bug 234007
[libpas] Fix up missing header includes and build guards in unit tests 
https://bugs.webkit.org/show_bug.cgi?id=234007
Summary [libpas] Fix up missing header includes and build guards in unit tests
Zan Dobersek
Reported 2021-12-08 07:32:41 PST
[libpas] Fix up missing header includes and build guards in unit tests
Attachments
Patch (6.34 KB, patch)
2021-12-08 07:32 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (7.26 KB, patch)
2021-12-09 00:45 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2021-12-08 07:32:56 PST
Created attachment 446363 [details] Patch
Yusuke Suzuki
Comment 2 2021-12-08 11:19:22 PST
Comment on attachment 446363 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=446363&action=review > Source/bmalloc/libpas/src/test/IsoHeapChaosTests.cpp:622 > +#if PAS_OS(DARWIN) > for (pthread_t thread : runningThreads) { > kern_return_t result = thread_suspend(pthread_mach_thread_np(thread)); > PAS_ASSERT(result == KERN_SUCCESS); > } > +#endif If we cannot suspend and resume threads, then this test is broken. So you need to disable this test for that platforms.
Zan Dobersek
Comment 3 2021-12-09 00:45:15 PST
Created attachment 446506 [details] Patch Disabled enumerator tests in IsoHeapChaosTests for Linux, due to the missing thread suspension/resuming. Also adjusted inclusions so that they follow the existing order.
EWS
Comment 4 2021-12-09 03:24:43 PST
Committed r286773 (245014@main): <https://commits.webkit.org/245014@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446506 [details].
Radar WebKit Bug Importer
Comment 5 2021-12-09 03:25:23 PST
<rdar://problem/86263339>
Note You need to log in before you can comment on or make changes to this bug.