Bug 233979 - Make FontCascade::s_codePath thread safe
Summary: Make FontCascade::s_codePath thread safe
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks: 233488
  Show dependency tree / graph
 
Reported: 2021-12-07 22:30 PST by Cameron McCormack (:heycam)
Modified: 2022-09-11 16:21 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.40 KB, patch)
2021-12-07 22:40 PST, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Patch (31.13 KB, patch)
2021-12-09 21:48 PST, Cameron McCormack (:heycam) 		mmaxfield: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-12-07 22:30:11 PST 
Make FontCascade::s_codePath thread safe
Comment 1 Cameron McCormack (:heycam) 2021-12-07 22:40:30 PST 
Created attachment 446305 [details]
Patch
Comment 2 Myles C. Maxfield 2021-12-08 21:09:07 PST 
Comment on attachment 446305 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446305&action=review

> Source/WebCore/ChangeLog:3
> +        Make FontCascade::s_codePath thread safe

Can we just delete it instead?
Comment 3 Cameron McCormack (:heycam) 2021-12-09 21:48:31 PST 
Created attachment 446658 [details]
Patch
Comment 4 Cameron McCormack (:heycam) 2021-12-09 21:49:19 PST 
(In reply to Myles C. Maxfield from comment #2)
> Can we just delete it instead?

Let's try.  It involves more code removal than I thought.
Comment 5 Radar WebKit Bug Importer 2021-12-14 22:31:16 PST 
<rdar://problem/86506735>
Comment 6 Myles C. Maxfield 2022-09-07 19:43:27 PDT 
Comment on attachment 446658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446658&action=review

I think this is right but I think we should run this by a GTK port contributor before landing.

> Source/WebCore/ChangeLog:14
> +        - making the Gtk port go back to effectively using CodePath::Auto

I thought the GTK port _only_ had the complex text codepath. Maybe I'm misinformed?
Comment 7 Matt Woodrow 2022-09-11 16:21:50 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4242