Bug 233957 – [iOS] Add support for _UITextSearchOptions when finding a string

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Aditya Keerthi]

...

[Aditya Keerthi]

rdar://86140673

[Aditya Keerthi]

Created attachment 446250 [details]
Patch

[Aditya Keerthi]

Patch will not apply until https://bugs.webkit.org/show_bug.cgi?id=233915 is landed, but this is ready for review.

[Wenson Hsieh]

Comment on attachment 446250 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446250&action=review

r=me! (assuming EWS is happy with this, after #233915 lands)

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9970
> +        findOptions.add(WebKit::FindOptions::AtWordStarts);
> +        findOptions.add(WebKit::FindOptions::AtWordEnds);

Nit - I think you can just do `.add({ WebKit::FindOptions::AtWordStarts, WebKit::FindOptions::AtWordEnds });` here.

[Aditya Keerthi]

(In reply to Wenson Hsieh from comment #4)
> Comment on attachment 446250 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=446250&action=review
> 
> r=me! (assuming EWS is happy with this, after #233915 lands)
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9970
> > +        findOptions.add(WebKit::FindOptions::AtWordStarts);
> > +        findOptions.add(WebKit::FindOptions::AtWordEnds);
> 
> Nit - I think you can just do `.add({ WebKit::FindOptions::AtWordStarts,
> WebKit::FindOptions::AtWordEnds });` here.

Thanks for the review! Will make this change after #233915 lands.

[Aditya Keerthi]

Created attachment 446289 [details]
Patch for landing

[EWS]

Committed r286660 (244973@main): <https://commits.webkit.org/244973@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446289 [details].