Bug 233952 - Update ANGLE changes.diff with new roll.
Summary: Update ANGLE changes.diff with new roll.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kyle Piddington
URL:
Keywords: InRadar
Depends on: 220896
Blocks:
  Show dependency tree / graph
 
Reported: 2021-12-07 13:49 PST by Kyle Piddington
Modified: 2021-12-08 13:30 PST (History)
9 users (show)

See Also:

Attachments
Patch (137.97 KB, patch)
2021-12-07 13:50 PST, Kyle Piddington 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Piddington 2021-12-07 13:49:52 PST 
Update ANGLE changes.diff with new roll.
Comment 1 Kyle Piddington 2021-12-07 13:50:22 PST 
Created attachment 446233 [details]
Patch
Comment 2 EWS Watchlist 2021-12-07 13:51:38 PST 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kenneth Russell 2021-12-08 12:50:08 PST 
Gregg, does this patch address your whitespace concerns?

Kyle, can you provide a little more background about why this was needed? I thought it should have been handled automatically by the update-angle script during the last roll, and every roll.
Comment 4 Kenneth Russell 2021-12-08 12:55:34 PST 
The mega-roll in question was from Bug 220896.
Comment 5 Kenneth Russell 2021-12-08 13:00:51 PST 
Comment on attachment 446233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446233&action=review

This update looks fine to me - let's please work together to upstream as many of the remaining changes as possible, as soon as possible. r+

> Source/ThirdParty/ANGLE/changes.diff:1782
> ++            if (metalDevice.depth24Stencil8PixelFormatSupported &&                                  !display->getFeatures().forceD24S8AsUnsupported.enabled)

This and some of the other whitespace changes are a bit unfortunate. Can they be cleaned up?
Comment 6 EWS 2021-12-08 13:29:58 PST 
Committed r286736 (244987@main): <https://commits.webkit.org/244987@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446233 [details].
Comment 7 Radar WebKit Bug Importer 2021-12-08 13:30:30 PST 
<rdar://problem/86227239>