Bug 233904 - [commits.webkit.org] Fallback to remote repository
Summary: [commits.webkit.org] Fallback to remote repository
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-06 17:07 PST by Jonathan Bedard
Modified: 2021-12-07 16:25 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.47 KB, patch)
2021-12-07 09:58 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (2.05 KB, patch)
2021-12-07 13:20 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-12-06 17:07:02 PST
We replaced commits.webkit.org with a version that has an actual checkout. This works well, unless a commit has just landed, because the git mirror won't have picked it up yet.
Comment 1 Radar WebKit Bug Importer 2021-12-06 17:18:04 PST
<rdar://problem/86131927>
Comment 2 Jonathan Bedard 2021-12-07 09:58:42 PST
Created attachment 446194 [details]
Patch
Comment 3 Jonathan Bedard 2021-12-07 09:59:01 PST
PR for part 1: https://github.com/WebKit/WebKit/pull/53
Comment 4 dewei_zhu 2021-12-07 11:39:38 PST
Comment on attachment 446194 [details]
Patch

r=me
Comment 5 Jonathan Bedard 2021-12-07 13:12:48 PST
(In reply to dewei_zhu from comment #4)
> Comment on attachment 446194 [details]
> Patch
> 
> r=me

I'm going to deploy this before landing it to make sure it actually fixes the issue.
Comment 6 Jonathan Bedard 2021-12-07 13:20:10 PST
Created attachment 446231 [details]
Patch
Comment 7 Jonathan Bedard 2021-12-07 15:35:27 PST
Going to land this, it works well: https://ews-build.webkit.org/#/builders/28
Comment 8 EWS 2021-12-07 16:25:43 PST
Committed r286629 (244942@main): <https://commits.webkit.org/244942@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446231 [details].