Bug 233883 - Use more specific keys for pseudo-class invalidation
Summary: Use more specific keys for pseudo-class invalidation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-06 10:44 PST by Antti Koivisto
Modified: 2021-12-07 09:50 PST (History)
9 users (show)

See Also:

Attachments
Patch (21.05 KB, patch)
2021-12-06 10:48 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (24.17 KB, patch)
2021-12-06 12:53 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (24.24 KB, patch)
2021-12-07 00:32 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-12-06 10:44:10 PST 
Currently pseudo-class invalidation is keyed on the pseudo-class type only. If we have rule like

.foo:hover { ... }

we end up considering this rule every time any element's :hover state changes, whether it has class 'foo' or not.

We can improve this by keying pseudo-class invalidation more narrowly on type/class or type/id pairs.
Comment 1 Antti Koivisto 2021-12-06 10:48:17 PST 
Created attachment 446053 [details]
Patch
Comment 2 Antti Koivisto 2021-12-06 12:53:18 PST 
Created attachment 446071 [details]
Patch
Comment 3 Antti Koivisto 2021-12-07 00:32:01 PST 
Created attachment 446134 [details]
Patch
Comment 4 EWS 2021-12-07 09:49:58 PST 
Committed r286598 (?): <https://commits.webkit.org/r286598>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446134 [details].
Comment 5 Radar WebKit Bug Importer 2021-12-07 09:50:23 PST 
<rdar://problem/86161876>