Bug 233728 - AX Isolated Tree: Document links should be stored in web areas, not the root
Summary: AX Isolated Tree: Document links should be stored in web areas, not the root
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-12-01 15:00 PST by Tyler Wilcock
Modified: 2021-12-03 11:21 PST (History)
10 users (show)

See Also:

Attachments
Patch (7.82 KB, patch)
2021-12-01 15:28 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (7.79 KB, patch)
2021-12-01 15:30 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2021-12-01 15:00:32 PST 
In WebAccessibilityObjectWrapperMac.mm, we expose the document links attribute (AXLinkUIElements) on web areas. However, in AXIsolatedObject::initializeAttributeData we currently only store AXPropertyName::DocumentLinks for the root element, which is not a web area. This causes accessibility/visible-elements.html to fail.

https://github.com/WebKit/WebKit/blob/109c8234854a0fa28955d81994bb98daa1fa14fe/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm#L2235#L2237
Comment 1 Radar WebKit Bug Importer 2021-12-01 15:00:52 PST 
<rdar://problem/85941419>
Comment 2 Tyler Wilcock 2021-12-01 15:28:03 PST 
Created attachment 445625 [details]
Patch
Comment 3 Tyler Wilcock 2021-12-01 15:30:11 PST 
Created attachment 445626 [details]
Patch
Comment 4 EWS 2021-12-02 07:25:59 PST 
Committed r286426 (244772@main): <https://commits.webkit.org/244772@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445626 [details].