Bug 233689 – REGRESSION (r286346): ResourceLoadDelegate.LoadInfo fails

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

REGRESSION (r286346): ResourceLoadDelegate.LoadInfo fails

[Tim Horton]

Created attachment 445533 [details]
Patch

[EWS]

Committed r286368 (244727@main): <https://commits.webkit.org/244727@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445533 [details].

[Radar WebKit Bug Importer]

<rdar://problem/85926760>

[Darin Adler]

Comment on attachment 445533 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445533&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:-382
> -    EXPECT_EQ(archiveData.length, 607ull);

Another comment from my new crusade, on this deleted code, so that observers will learn what I have recently learned: This is backwards, the actual value first and then the expected. The GTest macros take the expected value first and the actual value second. Getting this right helps the clarity of the message when the expectation is not met.

[Darin Adler]

(In reply to Darin Adler from comment #4)
> Another comment from my new crusade, on this deleted code, so that observers
> will learn what I have recently learned: This is backwards, the actual value
> first and then the expected. The GTest macros take the expected value first
> and the actual value second. Getting this right helps the clarity of the
> message when the expectation is not met.

Now I am not sure; the error message someone mentioned in a Slack discussion seems to be more even-handed than I thought, so my comment may be out of date.