Bug 233689 - REGRESSION (r286346): ResourceLoadDelegate.LoadInfo fails
Summary: REGRESSION (r286346): ResourceLoadDelegate.LoadInfo fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-30 23:58 PST by Tim Horton
Modified: 2021-12-01 11:38 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.71 KB, patch)
2021-11-30 23:58 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-11-30 23:58:13 PST 
REGRESSION (r286346): ResourceLoadDelegate.LoadInfo fails
Comment 1 Tim Horton 2021-11-30 23:58:50 PST 
Created attachment 445533 [details]
Patch
Comment 2 EWS 2021-12-01 09:50:38 PST 
Committed r286368 (244727@main): <https://commits.webkit.org/244727@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445533 [details].
Comment 3 Radar WebKit Bug Importer 2021-12-01 09:51:35 PST 
<rdar://problem/85926760>
Comment 4 Darin Adler 2021-12-01 09:59:11 PST 
Comment on attachment 445533 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445533&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:-382
> -    EXPECT_EQ(archiveData.length, 607ull);

Another comment from my new crusade, on this deleted code, so that observers will learn what I have recently learned: This is backwards, the actual value first and then the expected. The GTest macros take the expected value first and the actual value second. Getting this right helps the clarity of the message when the expectation is not met.
Comment 5 Darin Adler 2021-12-01 11:38:20 PST 
(In reply to Darin Adler from comment #4)
> Another comment from my new crusade, on this deleted code, so that observers
> will learn what I have recently learned: This is backwards, the actual value
> first and then the expected. The GTest macros take the expected value first
> and the actual value second. Getting this right helps the clarity of the
> message when the expectation is not met.

Now I am not sure; the error message someone mentioned in a Slack discussion seems to be more even-handed than I thought, so my comment may be out of date.