RESOLVED FIXED Bug 233641
REGRESSION(r286272): Wrong approach to disabling experimental features.
https://bugs.webkit.org/show_bug.cgi?id=233641
Summary REGRESSION(r286272): Wrong approach to disabling experimental features.
WebKit Commit Bot
Reported 2021-11-30 09:06:08 PST
https://commits.webkit.org/r286272 introduced a regression: Wrong approach to disabling experimental features. This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
REVERT of r286272 (8.40 KB, patch)
2021-11-30 09:06 PST, WebKit Commit Bot
no flags
Patch v2 for landing (4.79 KB, patch)
2021-11-30 09:10 PST, David Kilzer (:ddkilzer)
no flags
WebKit Commit Bot
Comment 1 2021-11-30 09:06:18 PST
Created attachment 445424 [details] REVERT of r286272 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
David Kilzer (:ddkilzer)
Comment 2 2021-11-30 09:10:29 PST
Created attachment 445425 [details] Patch v2 for landing
David Kilzer (:ddkilzer)
Comment 3 2021-11-30 09:11:24 PST
(In reply to David Kilzer (:ddkilzer) from comment #2) > Created attachment 445425 [details] > Patch v2 for landing Keeping the ENABLE(MODEL_ELEMENT) changes as this were fine.
EWS
Comment 4 2021-11-30 10:10:42 PST
Committed r286304 (244663@main): <https://commits.webkit.org/244663@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445425 [details].
Radar WebKit Bug Importer
Comment 5 2021-11-30 10:11:42 PST
Note You need to log in before you can comment on or make changes to this bug.