Bug 233641 - REGRESSION(r286272): Wrong approach to disabling experimental features.
Summary: REGRESSION(r286272): Wrong approach to disabling experimental features.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords: InRadar
Depends on:
Blocks: 233152
  Show dependency tree / graph
 
Reported: 2021-11-30 09:06 PST by WebKit Commit Bot
Modified: 2021-11-30 10:11 PST (History)
7 users (show)

See Also:

Attachments
REVERT of r286272 (8.40 KB, patch)
2021-11-30 09:06 PST, WebKit Commit Bot 		no flags Details | Formatted Diff | Diff
Patch v2 for landing (4.79 KB, patch)
2021-11-30 09:10 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2021-11-30 09:06:08 PST 
https://commits.webkit.org/r286272 introduced a regression:
Wrong approach to disabling experimental features.

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2021-11-30 09:06:18 PST 
Created attachment 445424 [details]
REVERT of r286272

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 David Kilzer (:ddkilzer) 2021-11-30 09:10:29 PST 
Created attachment 445425 [details]
Patch v2 for landing
Comment 3 David Kilzer (:ddkilzer) 2021-11-30 09:11:24 PST 
(In reply to David Kilzer (:ddkilzer) from comment #2)
> Created attachment 445425 [details]
> Patch v2 for landing

Keeping the ENABLE(MODEL_ELEMENT) changes as this were fine.
Comment 4 EWS 2021-11-30 10:10:42 PST 
Committed r286304 (244663@main): <https://commits.webkit.org/244663@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445425 [details].
Comment 5 Radar WebKit Bug Importer 2021-11-30 10:11:42 PST 
<rdar://problem/85871810>