Bug 233389 – [WebAuthn] Consider support for the displayName for FIDO authenticator

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[[e-mail]]

Vendors have requested that we support displayName for platform authenticator. Adding icon while at it.

[[e-mail]]

rdar://84938707

[[e-mail]]

Created attachment 444868 [details]
Patch

[[e-mail]]

Created attachment 446049 [details]
Patch

[Brent Fulgham]

Comment on attachment 446049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446049&action=review

> Source/WebKit/ChangeLog:9
> +        Start storing the displayName and icon fields with the platform authenticator

Are these part of the WebAuthn spec? If so, could you add comments in the code indicating the relevant spec step to make it easy to find/validate this later?

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:271
> +        [credential setDictionary:@{

Could also be done with 'initWithObjectsAndKeys: ', but I doubt there's any real performance benefit to doing so.

[[e-mail]]

Created attachment 446381 [details]
Patch

[[e-mail]]

Thank you for the review.

Addressed comments and removed icon from the change, as it is a field that was removed from the webauthn spec in: https://github.com/w3c/webauthn/pull/1337

[Brent Fulgham]

Comment on attachment 446381 [details]
Patch

r=me. Nice!

[EWS]

Committed r286746 (244991@main): <https://commits.webkit.org/244991@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446381 [details].