Bug 233241 – Convert error to string before passing to testFailed() in FileSystemAccess layout tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Sihui Liu]

...

[Sihui Liu]

Created attachment 444483 [details]
Patch

[youenn fablet]

Comment on attachment 444483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444483&action=review

> LayoutTests/ChangeLog:8
> +        testFailed() in js-test.js expects string, but finishTest() may receive Error object as parameter.

Proposed approach is fine, but why not updating testFailed to pretty print Error itself?

> LayoutTests/storage/filesystemaccess/resources/shared.js:8
> +        }

We usually do not need { } for one liner if.

[Radar WebKit Bug Importer]

<rdar://problem/85718910>

[Sihui Liu]

Comment on attachment 444483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444483&action=review

>> LayoutTests/ChangeLog:8
>> +        testFailed() in js-test.js expects string, but finishTest() may receive Error object as parameter.
> 
> Proposed approach is fine, but why not updating testFailed to pretty print Error itself?

testFailed() has always received string as parameter, and it's symmetric to testPassed(), so I didn't change it in js-test.js. 
But it may be worthwhile to make the change if we see other tests have the same issue.

>> LayoutTests/storage/filesystemaccess/resources/shared.js:8
>> +        }
> 
> We usually do not need { } for one liner if.

Will remove.

[Sihui Liu]

Created attachment 445239 [details]
Patch for landing

[EWS]

Committed r286198 (244580@main): <https://commits.webkit.org/244580@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445239 [details].