Bug 233221 - REGRESSION(r285859) [GTK][WPE] a number of accessibility/* tests crash on GTK and WPE
Summary: REGRESSION(r285859) [GTK][WPE] a number of accessibility/* tests crash on GTK...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Arcady Goldmints-Orlov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-16 16:48 PST by Arcady Goldmints-Orlov
Modified: 2021-11-19 01:01 PST (History)
14 users (show)

See Also:

Attachments
Patch (2.14 KB, patch)
2021-11-16 17:03 PST, Arcady Goldmints-Orlov 		no flags Details | Formatted Diff | Diff
Patch (4.67 KB, patch)
2021-11-17 14:47 PST, Arcady Goldmints-Orlov 		no flags Details | Formatted Diff | Diff
Patch (7.45 KB, patch)
2021-11-18 18:16 PST, Arcady Goldmints-Orlov 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arcady Goldmints-Orlov 2021-11-16 16:48:50 PST 
A number of accessibility tests have started crashing after r285859 added a new runtime assert to AccessibilityUIElement::create()

Regressions: Unexpected crashes (12)
  accessibility/aria-hidden-false-works-in-subtrees.html [ Crash ]
  accessibility/aria-hidden-updates-alldescendants.html [ Crash ]
  accessibility/aria-modal-text-descendants.html [ Crash ]
  accessibility/auto-fill-types.html [ Crash ]
  accessibility/hidden-th-still-column-header.html [ Crash ]
  accessibility/onclick-handlers.html [ Crash ]
  accessibility/removed-anonymous-block-child-causes-crash.html [ Crash ]
  accessibility/removed-continuation-element-causes-crash.html [ Crash ]
  accessibility/scroll-to-make-visible-iframe-offscreen.html [ Crash ]
  accessibility/svg-text.html [ Crash ]
  accessibility/table-cell-display-block.html [ Crash ]
  accessibility/table-notbody.html [ Crash ]
Comment 1 Radar WebKit Bug Importer 2021-11-16 16:49:07 PST 
<rdar://problem/85481838>
Comment 2 Arcady Goldmints-Orlov 2021-11-16 17:03:13 PST 
Created attachment 444456 [details]
Patch
Comment 3 Arcady Goldmints-Orlov 2021-11-16 17:12:01 PST 
The current version of the patch causes a couple of failures (regressions from the previous status quo), as opposed to crashes (current status quo):

Regressions: Unexpected text-only failures (2)
  accessibility/aria-modal-text-descendants.html [ Failure ]
  accessibility/table-cell-display-block.html [ Failure ]
Comment 4 Tyler Wilcock 2021-11-16 17:28:44 PST 
Sorry for the breakage, Arcady. I checked GTK's usage of AccessibilityUIElement::create() and it all looked OK, but clearly I missed some.

Regarding the text failures:

  accessibility/aria-modal-text-descendants.html [ Failure ]
  accessibility/table-cell-display-block.html [ Failure ]

https://commits.webkit.org/r285859 prevents the creation of a UI element backed by a null pointer, which always seems like the correct thing to do. Do the text differences look easily reconcilable?
Comment 5 Arcady Goldmints-Orlov 2021-11-17 14:47:08 PST 
Created attachment 444583 [details]
Patch
Comment 6 Carlos Garcia Campos 2021-11-18 04:43:16 PST 
Comment on attachment 444583 [details]
Patch

We also need to handle nullptr in AccessibilityController::focusedElement().
Comment 7 Arcady Goldmints-Orlov 2021-11-18 18:16:59 PST 
Created attachment 444765 [details]
Patch
Comment 8 EWS 2021-11-19 01:01:46 PST 
Committed r286052 (244439@main): <https://commits.webkit.org/244439@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444765 [details].