Bug 233213 - [iOS] use PhotosUIPrivate instead of PhotosUI
Summary: [iOS] use PhotosUIPrivate instead of PhotosUI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-16 14:18 PST by Devin Rousso
Modified: 2021-11-16 18:39 PST (History)
7 users (show)

See Also:

Attachments
Patch (3.05 KB, patch)
2021-11-16 14:19 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (3.06 KB, patch)
2021-11-16 14:44 PST, Devin Rousso 		akeerthi: review+
Details | Formatted Diff | Diff
Patch (3.07 KB, patch)
2021-11-16 14:58 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-11-16 14:18:08 PST 
.
Comment 1 Devin Rousso 2021-11-16 14:18:31 PST 
<rdar://problem/85300427>
Comment 2 Devin Rousso 2021-11-16 14:19:06 PST 
Created attachment 444429 [details]
Patch
Comment 3 Devin Rousso 2021-11-16 14:44:33 PST 
Created attachment 444435 [details]
Patch
Comment 4 Aditya Keerthi 2021-11-16 14:50:25 PST 
Comment on attachment 444435 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444435&action=review

r=me

> Source/WebKit/Platform/spi/ios/PhotosUISPI.h:30
> +#else

I think this should be `#elif HAVE(PHOTOS_UI)`, so we don't try to import on watchOS/tvOS.
Comment 5 Devin Rousso 2021-11-16 14:58:22 PST 
Created attachment 444440 [details]
Patch
Comment 6 EWS 2021-11-16 18:39:54 PST 
Committed r285910 (244319@main): <https://commits.webkit.org/244319@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444440 [details].