WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
233213
[iOS] use PhotosUIPrivate instead of PhotosUI
https://bugs.webkit.org/show_bug.cgi?id=233213
Summary
[iOS] use PhotosUIPrivate instead of PhotosUI
Devin Rousso
Reported
2021-11-16 14:18:08 PST
.
Attachments
Patch
(3.05 KB, patch)
2021-11-16 14:19 PST
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Patch
(3.06 KB, patch)
2021-11-16 14:44 PST
,
Devin Rousso
akeerthi
: review+
Details
Formatted Diff
Diff
Patch
(3.07 KB, patch)
2021-11-16 14:58 PST
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Devin Rousso
Comment 1
2021-11-16 14:18:31 PST
<
rdar://problem/85300427
>
Devin Rousso
Comment 2
2021-11-16 14:19:06 PST
Created
attachment 444429
[details]
Patch
Devin Rousso
Comment 3
2021-11-16 14:44:33 PST
Created
attachment 444435
[details]
Patch
Aditya Keerthi
Comment 4
2021-11-16 14:50:25 PST
Comment on
attachment 444435
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=444435&action=review
r=me
> Source/WebKit/Platform/spi/ios/PhotosUISPI.h:30 > +#else
I think this should be `#elif HAVE(PHOTOS_UI)`, so we don't try to import on watchOS/tvOS.
Devin Rousso
Comment 5
2021-11-16 14:58:22 PST
Created
attachment 444440
[details]
Patch
EWS
Comment 6
2021-11-16 18:39:54 PST
Committed
r285910
(
244319@main
): <
https://commits.webkit.org/244319@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 444440
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug