Bug 233175 - RemoteGraphicsContextGLProxyBase should not have platform-specific implementations
Summary: RemoteGraphicsContextGLProxyBase should not have platform-specific implementa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: 233123
  Show dependency treegraph
 
Reported: 2021-11-16 00:24 PST by Kimmo Kinnunen
Modified: 2021-11-18 12:44 PST (History)
16 users (show)

See Also:


Attachments
Patch (31.51 KB, patch)
2021-11-16 01:02 PST, Kimmo Kinnunen
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (31.63 KB, patch)
2021-11-16 01:25 PST, Kimmo Kinnunen
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (32.32 KB, patch)
2021-11-16 01:58 PST, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (32.33 KB, patch)
2021-11-16 03:41 PST, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch for landing (31.70 KB, patch)
2021-11-16 23:38 PST, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-11-16 00:24:03 PST
RemoteGraphicsContextGLProxyBase should not have platform-specific implementations
It is a simple class mostly existing for no good reason
The concrete class RemoteGraphicsContextGLProxy has Cocoa and WC implementations. The platform-specific code should move there.
Comment 1 Kimmo Kinnunen 2021-11-16 01:02:17 PST
Created attachment 444353 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-11-16 01:25:11 PST
Created attachment 444356 [details]
Patch
Comment 3 Kimmo Kinnunen 2021-11-16 01:58:21 PST
Created attachment 444359 [details]
Patch
Comment 4 Kimmo Kinnunen 2021-11-16 03:41:26 PST
Created attachment 444369 [details]
Patch
Comment 5 Antti Koivisto 2021-11-16 06:27:32 PST
Comment on attachment 444369 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444369&action=review

> Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.messages.in:1
> +´# Copyright (C) 2020 Apple Inc. All rights reserved.

Some junk here.
Comment 6 Kimmo Kinnunen 2021-11-16 23:38:11 PST
Created attachment 444484 [details]
Patch for landing
Comment 7 EWS 2021-11-18 01:49:52 PST
Committed r285990 (244387@main): <https://commits.webkit.org/244387@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444484 [details].
Comment 8 Radar WebKit Bug Importer 2021-11-18 01:50:26 PST
<rdar://problem/85541122>