Bug 233034 - [JSC][32bit] Unskip JSTests/microbenchmarks/redefine-property-accessor-dictionary.js
Summary: [JSC][32bit] Unskip JSTests/microbenchmarks/redefine-property-accessor-dictio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-12 02:56 PST by Xan Lopez
Modified: 2021-11-12 03:44 PST (History)
2 users (show)

See Also:


Attachments
v1 (2.23 KB, patch)
2021-11-12 02:57 PST, Xan Lopez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
v2 (2.22 KB, patch)
2021-11-12 03:13 PST, Xan Lopez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2021-11-12 02:56:06 PST
This is skipped for memoryLimited *and* mips|arm systems, but a) seems to run fine on both setups and b) is almost identical to the other tests/benchmarks that landed in the same patch, that do not have that limitation. Optimistically remove the skip and let's see if it sticks.
Comment 1 Xan Lopez 2021-11-12 02:57:25 PST
Created attachment 444054 [details]
v1
Comment 2 EWS 2021-11-12 02:58:15 PST
ChangeLog entry in JSTests/ChangeLog contains OOPS!.
Comment 3 Xan Lopez 2021-11-12 03:13:46 PST
Created attachment 444056 [details]
v2

Mark it as gardening!
Comment 4 EWS 2021-11-12 03:43:34 PST
Committed r285712 (244171@main): <https://commits.webkit.org/244171@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444056 [details].
Comment 5 Radar WebKit Bug Importer 2021-11-12 03:44:20 PST
<rdar://problem/85337961>