Bug 232985 - Set default general storage directory to websiteDataDirectory
Summary: Set default general storage directory to websiteDataDirectory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-10 23:58 PST by Sihui Liu
Modified: 2021-11-12 15:12 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.00 KB, patch)
2021-11-11 09:11 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (15.75 KB, patch)
2021-11-11 21:51 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (15.26 KB, patch)
2021-11-12 11:23 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (15.25 KB, patch)
2021-11-12 14:41 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2021-11-10 23:58:17 PST 
...
Comment 1 Sihui Liu 2021-11-11 09:11:38 PST 
Created attachment 443955 [details]
Patch
Comment 2 Sihui Liu 2021-11-11 21:51:11 PST 
Created attachment 444043 [details]
Patch
Comment 3 Sihui Liu 2021-11-12 11:23:48 PST 
Created attachment 444084 [details]
Patch
Comment 4 Geoffrey Garen 2021-11-12 13:47:40 PST 
Comment on attachment 444084 [details]
Patch

r=me

I think for most storage types we'll need to do migration more incrementally; but this storage type has not been used much, so one-shot seems fine.
Comment 5 Sihui Liu 2021-11-12 14:41:01 PST 
Created attachment 444111 [details]
Patch for landing
Comment 6 EWS 2021-11-12 15:11:50 PST 
Committed r285746 (244205@main): <https://commits.webkit.org/244205@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444111 [details].
Comment 7 Radar WebKit Bug Importer 2021-11-12 15:12:20 PST 
<rdar://problem/85359301>