Bug 232911 – Enable dialog tests on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Tim Nguyen (:ntim)]

Lots of tests were skipped because of "dialog.showModal() is undefined"

Presumably https://webkit-search.igalia.com/webkit/source/Source/WebCore/page/RuntimeEnabledFeatures.h#295 needs flipping

[Tim Nguyen (:ntim)]

Created attachment 443744 [details]
Patch

[Tim Nguyen (:ntim)]

Created attachment 443776 [details]
Patch

[youenn fablet]

Comment on attachment 443776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443776&action=review

> Source/WebCore/page/RuntimeEnabledFeatures.h:295
> +    bool m_dialogElementEnabled { true };

It does not seem a runtime flag is needed here.
Can we instead move from a runtime flag to a settings in WebPreferencesExperimental?

[Tim Nguyen (:ntim)]

(In reply to youenn fablet from comment #3)
> Comment on attachment 443776 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443776&action=review
> 
> > Source/WebCore/page/RuntimeEnabledFeatures.h:295
> > +    bool m_dialogElementEnabled { true };
> 
> It does not seem a runtime flag is needed here.
> Can we instead move from a runtime flag to a settings in
> WebPreferencesExperimental?

It already exists: https://webkit-search.igalia.com/webkit/source/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml#439-451

[youenn fablet]

Comment on attachment 443776 [details]
Patch

It would be nice to move to a Settings, can we file a bug to track this one?

[EWS]

Committed r285569 (244077@main): <https://commits.webkit.org/244077@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443776 [details].

[Radar WebKit Bug Importer]

<rdar://problem/85244734>