Lots of tests were skipped because of "dialog.showModal() is undefined" Presumably https://webkit-search.igalia.com/webkit/source/Source/WebCore/page/RuntimeEnabledFeatures.h#295 needs flipping
Created attachment 443744 [details] Patch
Created attachment 443776 [details] Patch
Comment on attachment 443776 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443776&action=review > Source/WebCore/page/RuntimeEnabledFeatures.h:295 > + bool m_dialogElementEnabled { true }; It does not seem a runtime flag is needed here. Can we instead move from a runtime flag to a settings in WebPreferencesExperimental?
(In reply to youenn fablet from comment #3) > Comment on attachment 443776 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443776&action=review > > > Source/WebCore/page/RuntimeEnabledFeatures.h:295 > > + bool m_dialogElementEnabled { true }; > > It does not seem a runtime flag is needed here. > Can we instead move from a runtime flag to a settings in > WebPreferencesExperimental? It already exists: https://webkit-search.igalia.com/webkit/source/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml#439-451
Comment on attachment 443776 [details] Patch It would be nice to move to a Settings, can we file a bug to track this one?
Committed r285569 (244077@main): <https://commits.webkit.org/244077@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443776 [details].
<rdar://problem/85244734>