Bug 232661 - [WebGPU] Bindings Part 7: Bring back command encoder bindings code
Summary: [WebGPU] Bindings Part 7: Bring back command encoder bindings code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-03 04:52 PDT by Myles C. Maxfield
Modified: 2021-11-06 16:05 PDT (History)
17 users (show)

See Also:


Attachments
Patch (299.79 KB, patch)
2021-11-03 04:53 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (299.41 KB, patch)
2021-11-03 13:06 PDT, Myles C. Maxfield
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-11-03 04:52:01 PDT
[WebGPU] Bindings Part 7: Bring back command encoder bindings code
Comment 1 Myles C. Maxfield 2021-11-03 04:53:25 PDT
Created attachment 443190 [details]
Patch
Comment 2 Myles C. Maxfield 2021-11-03 13:06:08 PDT
Created attachment 443231 [details]
Patch
Comment 3 Dean Jackson 2021-11-04 09:28:12 PDT
Comment on attachment 443231 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443231&action=review

rs=me

> Source/WebCore/Modules/WebGPU/GPURenderPassEncoder.idl:41
> +                     float width, float height,
> +                     float minDepth, float maxDepth);

weird indentation in this file
Comment 4 Myles C. Maxfield 2021-11-06 16:04:35 PDT
Committed r285382 (243939@main): <https://commits.webkit.org/243939@main>
Comment 5 Radar WebKit Bug Importer 2021-11-06 16:05:16 PDT
<rdar://problem/85105373>