WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
232636
[MSVC] Remove unused friend class in filter code
https://bugs.webkit.org/show_bug.cgi?id=232636
Summary
[MSVC] Remove unused friend class in filter code
Don Olmstead
Reported
2021-11-02 13:29:52 PDT
In a non-unified build after
r284857
which removed WTF:: prefixes causes an error with MSVC. It thinks there's a WebCore::ParallelJobs due to the friend class declaration in some filter classes. Remove them.
Attachments
Patch
(2.02 KB, patch)
2021-11-02 13:35 PDT
,
Don Olmstead
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Don Olmstead
Comment 1
2021-11-02 13:35:36 PDT
Created
attachment 443128
[details]
Patch
Yusuke Suzuki
Comment 2
2021-11-02 13:46:33 PDT
Comment on
attachment 443128
[details]
Patch r=me
EWS
Comment 3
2021-11-02 14:50:58 PDT
Committed
r285185
(
243814@main
): <
https://commits.webkit.org/243814@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 443128
[details]
.
Radar WebKit Bug Importer
Comment 4
2021-11-02 14:51:18 PDT
<
rdar://problem/84948344
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug