Bug 232525 - Fuzzy pixel data need to be computed in terms of CSS pixels
Summary: Fuzzy pixel data need to be computed in terms of CSS pixels
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on: 233609
Blocks: 149828
  Show dependency tree / graph
 
Reported: 2021-10-29 22:04 PDT by Simon Fraser (smfr)
Modified: 2021-12-21 21:16 PST (History)
6 users (show)

See Also:

Attachments
Patch (6.13 KB, patch)
2021-12-21 15:56 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-10-29 22:04:47 PDT 
The fuzzy pixel data probably need to be resolution-independent, so when we use 3x snapshots for iOS and hi-dpi tests, we need to adjust the fuzzy matching accordingly.
Comment 1 Radar WebKit Bug Importer 2021-11-05 22:05:17 PDT 
<rdar://problem/85095900>
Comment 2 Sam Sneddon [:gsnedders] 2021-12-14 09:52:07 PST 
see also https://github.com/web-platform-tests/wpt/issues/31457
Comment 3 Simon Fraser (smfr) 2021-12-21 15:56:04 PST 
Created attachment 447759 [details]
Patch
Comment 4 EWS 2021-12-21 21:16:52 PST 
Committed r287345 (245487@main): <https://commits.webkit.org/245487@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447759 [details].