Bug 232478 – ANGLE OpenGL: Cherry-pick commit GL: Fix bug with: Skip redundant flushes.

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: ANGLE

[Kimmo Kinnunen]

ANGLE OpenGL: Cherry-pick commit GL: Fix bug with: Skip redundant flushes.
ecf27c717f478fc0dfc880a982793fb120284431

[Kimmo Kinnunen]

Created attachment 442800 [details]
Patch

[Kenneth Russell]

Are you sure you want to cherry-pick this? I'm not sure it increased stability in Chrome, and will only make WebKit's and upstream ANGLE diverge further.

[Kimmo Kinnunen]

 (In reply to Kenneth Russell from comment #2)
> Are you sure you want to cherry-pick this? I'm not sure it increased
> stability in Chrome, and will only make WebKit's and upstream ANGLE diverge
> further.

If I understand correctly, bug 232476 is part of mitigation for the crashes.
That patch contains a bug that is fixed by this patch?

[Radar WebKit Bug Importer]

<rdar://problem/84981626>

[Kenneth Russell]

I see. Yes, these were all CLs associated with the parent bug (https://crbug.com/1181068). I'm not sure though how much the flush-related work improved stability. Maybe geofflang@ can comment. Chunking TexSubImage2D calls into 120 KB max chunks was the primary workaround for the kernel panics.

[Geoff Lang]

This patch definitely trended the total flush crashes down too. The largest fix was the final one which fixed some invalid GL usage in Chrome.

Won't this roll into WebKit when ANGLE synchronizes?

[Kenneth Russell]

Thanks Geoff. It will come into WebKit during the next ANGLE roll into WebKit. It was unclear whether the WebKit team needed this sooner - we're aiming for a matter of a week or two for that roll.

[Kimmo Kinnunen]

This was merged as part of ANGLE update.