Bug 232478 - ANGLE OpenGL: Cherry-pick commit GL: Fix bug with: Skip redundant flushes.
Summary: ANGLE OpenGL: Cherry-pick commit GL: Fix bug with: Skip redundant flushes.
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on: 232476
Blocks: 232472
  Show dependency tree / graph
 
Reported: 2021-10-29 00:34 PDT by Kimmo Kinnunen
Modified: 2022-08-11 02:59 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.97 KB, patch)
2021-10-29 02:39 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-10-29 00:34:25 PDT 
ANGLE OpenGL: Cherry-pick commit GL: Fix bug with: Skip redundant flushes.
ecf27c717f478fc0dfc880a982793fb120284431
Comment 1 Kimmo Kinnunen 2021-10-29 02:39:43 PDT 
Created attachment 442800 [details]
Patch
Comment 2 Kenneth Russell 2021-11-02 23:37:09 PDT 
Are you sure you want to cherry-pick this? I'm not sure it increased stability in Chrome, and will only make WebKit's and upstream ANGLE diverge further.
Comment 3 Kimmo Kinnunen 2021-11-03 10:16:30 PDT 
 (In reply to Kenneth Russell from comment #2)
> Are you sure you want to cherry-pick this? I'm not sure it increased
> stability in Chrome, and will only make WebKit's and upstream ANGLE diverge
> further.

If I understand correctly, bug 232476 is part of mitigation for the crashes.
That patch contains a bug that is fixed by this patch?
Comment 4 Radar WebKit Bug Importer 2021-11-03 10:46:32 PDT 
<rdar://problem/84981626>
Comment 5 Kenneth Russell 2021-11-04 15:45:24 PDT 
I see. Yes, these were all CLs associated with the parent bug (https://crbug.com/1181068). I'm not sure though how much the flush-related work improved stability. Maybe geofflang@ can comment. Chunking TexSubImage2D calls into 120 KB max chunks was the primary workaround for the kernel panics.
Comment 6 Geoff Lang 2021-11-08 09:09:49 PST 
This patch definitely trended the total flush crashes down too. The largest fix was the final one which fixed some invalid GL usage in Chrome.

Won't this roll into WebKit when ANGLE synchronizes?
Comment 7 Kenneth Russell 2021-11-08 14:00:02 PST 
Thanks Geoff. It will come into WebKit during the next ANGLE roll into WebKit. It was unclear whether the WebKit team needed this sooner - we're aiming for a matter of a week or two for that roll.
Comment 8 Kimmo Kinnunen 2022-08-11 02:59:12 PDT 
This was merged as part of ANGLE update.