Bug 232437 - Add WebPageProxy identifiers to `ViewGestures` category logging
Summary: Add WebPageProxy identifiers to `ViewGestures` category logging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-28 08:35 PDT by Wenson Hsieh
Modified: 2021-10-28 13:27 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.56 KB, patch)
2021-10-28 08:44 PDT, Wenson Hsieh
thorton: review+
Details | Formatted Diff | Diff
Patch (11.49 KB, patch)
2021-10-28 12:07 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-10-28 08:35:27 PDT
This makes it a lot easier to correlate ViewGestures release logging with ViewState logging (i.e. layer tree commits/visible content rect updates)
Comment 1 Wenson Hsieh 2021-10-28 08:44:01 PDT
Created attachment 442709 [details]
Patch
Comment 2 Wenson Hsieh 2021-10-28 12:03:12 PDT
Comment on attachment 442709 [details]
Patch

Thanks for the review!

(smfr requested that we log a pid in `-_didRelaunchProcess` as well, so I'll add that too before landing).
Comment 3 Wenson Hsieh 2021-10-28 12:07:10 PDT
Created attachment 442726 [details]
Patch
Comment 4 EWS 2021-10-28 13:26:35 PDT
Committed r284997 (243643@main): <https://commits.webkit.org/243643@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442726 [details].
Comment 5 Radar WebKit Bug Importer 2021-10-28 13:27:20 PDT
<rdar://problem/84774750>