Bug 232266 - webkitpy: Add an explicit ImageDiffResult.passed rather than relying on diff_image being non-None
Summary: webkitpy: Add an explicit ImageDiffResult.passed rather than relying on diff_...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-25 13:51 PDT by Simon Fraser (smfr)
Modified: 2021-10-25 16:26 PDT (History)
6 users (show)

See Also:


Attachments
Patch (18.70 KB, patch)
2021-10-25 13:55 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (18.69 KB, patch)
2021-10-25 14:04 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-10-25 13:51:15 PDT
webkitpy: Add an explicit ImageDiffResult.passed rather than relying on diff_image being non-None
Comment 1 Simon Fraser (smfr) 2021-10-25 13:55:13 PDT
Created attachment 442409 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-10-25 14:04:40 PDT
Created attachment 442412 [details]
Patch
Comment 3 EWS 2021-10-25 16:25:10 PDT
Committed r284845 (243522@main): <https://commits.webkit.org/243522@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442412 [details].
Comment 4 Radar WebKit Bug Importer 2021-10-25 16:26:18 PDT
<rdar://problem/84636930>