Bug 232198 – [GTK] REGRESSION (r270758): FreeBSD (libc++) build broken

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit2

GTK WebKit build on FreeBSD (uses libc++/clang) is regressed by:
https://github.com/WebKit/WebKit/commit/11ccaf183fad

GStreamer.cpp.o -c /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.34.0/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp
/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.34.0/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp:220:12: error: call to implicitly-deleted copy constructor of 'WebCore::PlatformSample'
    return sample;
           ^~~~~~

/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.34.0/Source/WebCore/platform/MediaSample.h:57:7: note: copy constructor of 'PlatformSample' is implicitly deleted because field 'sample' has a deleted copy constructor
    } sample;
      ^
/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.34.0/Source/WebCore/platform/MediaSample.h:56:66: note: copy constructor of '' is implicitly deleted because variant field 'byteRangeSample' has a non-trivial copy constructor
        std::pair<MTPluginByteSourceRef, CMFormatDescriptionRef> byteRangeSample;

1 error generated.

GCC build is also broken (results in SIGSEGV during build), so this is likely related to FreeBSD using libc++.

This is caused by std::pair ABI incompatibility in FreeBSD https://reviews.freebsd.org/D35327

[Charlie Li]

This should be obviated by bug 278596, but for future reference, std::pair copy constructors are never trivial in FreeBSD due to continued use of LLVM libc++ ABI version 1.