Bug 232121 - Remove release assertion in MediaResourceClient::responseReceived
Summary: Remove release assertion in MediaResourceClient::responseReceived
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-21 17:31 PDT by Alex Christensen
Modified: 2021-10-22 11:03 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.86 KB, patch)
2021-10-21 17:34 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (1.95 KB, patch)
2021-10-22 10:21 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-10-21 17:31:27 PDT
Remove assertion in MediaResourceClient::responseReceived
Comment 1 Alex Christensen 2021-10-21 17:34:26 PDT
Created attachment 442096 [details]
Patch
Comment 2 Alex Christensen 2021-10-21 17:34:30 PDT
<rdar://problem/79244664>
Comment 3 David Kilzer (:ddkilzer) 2021-10-22 10:17:33 PDT
Comment on attachment 442096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442096&action=review

r=me

> Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm:-216
> -        RELEASE_ASSERT_NOT_REACHED();

Do you want to change this to a Debug assertion?
Comment 4 Alex Christensen 2021-10-22 10:21:56 PDT
Created attachment 442175 [details]
Patch
Comment 5 EWS 2021-10-22 11:03:41 PDT
Committed r284694 (243413@main): <https://commits.webkit.org/243413@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442175 [details].