Bug 232026 - [libpas] Enable libpas on iOS family
Summary: [libpas] Enable libpas on iOS family
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-20 11:25 PDT by Yusuke Suzuki
Modified: 2021-11-09 11:21 PST (History)
3 users (show)

See Also:

Attachments
Patch (50.04 KB, patch)
2021-10-20 11:33 PDT, Yusuke Suzuki 		fpizlo: review+
Details | Formatted Diff | Diff
Patch (1.41 KB, patch)
2021-11-08 09:11 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-10-20 11:25:36 PDT 
This is based on https://bugs.webkit.org/show_bug.cgi?id=231815. So this patch includes the same content of https://bugs.webkit.org/show_bug.cgi?id=231815.
But when landing, we first land https://bugs.webkit.org/show_bug.cgi?id=231815, and only part of BPlatform.h change will be landed for this.
Comment 1 Yusuke Suzuki 2021-10-20 11:33:38 PDT 
Created attachment 441910 [details]
Patch
Comment 2 Yusuke Suzuki 2021-10-20 13:34:45 PDT 
Comment on attachment 441910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441910&action=review

> Source/bmalloc/bmalloc/BPlatform.h:314
> +#if BPLATFORM(COCOA) && BCPU(ADDRESS64)

Note that this patch is designed to be landed after libpas macOS enablement. So instead of using iOS family, it is using PLATFORM(COCOA).
Comment 3 Radar WebKit Bug Importer 2021-10-27 11:26:17 PDT 
<rdar://problem/84719678>
Comment 4 Yusuke Suzuki 2021-11-08 09:11:58 PST 
Created attachment 443555 [details]
Patch
Comment 5 EWS 2021-11-08 16:17:57 PST 
Committed r285442 (243995@main): <https://commits.webkit.org/243995@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443555 [details].
Comment 6 Yusuke Suzuki 2021-11-09 11:03:17 PST 
Committed r285512 (244033@main): <https://commits.webkit.org/244033@main>
Comment 7 Yusuke Suzuki 2021-11-09 11:21:15 PST 
Committed r285515 (244036@main): <https://commits.webkit.org/244036@main>