Bug 231977 - REGRESSION (r284220): [PAL] TCCSPI.h should be a project header, not a private header
Summary: REGRESSION (r284220): [PAL] TCCSPI.h should be a project header, not a privat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 231621
Blocks:
  Show dependency tree / graph
 
Reported: 2021-10-19 12:41 PDT by David Kilzer (:ddkilzer)
Modified: 2021-10-19 14:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1 (2.35 KB, patch)
2021-10-19 12:47 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2021-10-19 12:41:20 PDT 
TCCSPI.h should be a project header, not a private header.

Regressed in r284220 for Bug 231621.

<rdar://problem/84425384>
Comment 1 David Kilzer (:ddkilzer) 2021-10-19 12:47:33 PDT 
Created attachment 441772 [details]
Patch v1
Comment 2 Wenson Hsieh 2021-10-19 12:48:09 PDT 
Comment on attachment 441772 [details]
Patch v1

r=mews
Comment 3 David Kilzer (:ddkilzer) 2021-10-19 13:40:19 PDT 
Comment on attachment 441772 [details]
Patch v1

There are a quorum of successful Apple Cocoa builds, so marking cq+ since this patch is needed to fix builds on other internal build systems.

Note that ios, tv and tv-sim builders seem to be stuck on obsolete patches, and the mac build is ongoing (orange bubble is due to failed jinja Python module install, which isn't a hard failure, and is being investigated by Jonathan Bedard).
Comment 4 EWS 2021-10-19 14:10:46 PDT 
Committed r284494 (243248@main): <https://commits.webkit.org/243248@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441772 [details].