Bug 231868 - [webkitperl] Stop using LoadAsModule.pm
Summary: [webkitperl] Stop using LoadAsModule.pm
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 231869
  Show dependency tree / graph
 
Reported: 2021-10-16 14:54 PDT by Basuke Suzuki
Modified: 2022-04-26 01:34 PDT (History)
7 users (show)

See Also:

Attachments
PATCH (156.95 KB, patch)
2021-10-17 12:34 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
PATCH (157.53 KB, patch)
2021-10-17 12:42 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
PATCH (159.07 KB, patch)
2021-10-17 13:00 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
Stop using keyword-like usage of subroutine (158.38 KB, patch)
2021-10-18 09:39 PDT, Basuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Fix (158.25 KB, patch)
2021-10-18 10:30 PDT, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2021-10-16 14:54:34 PDT 
It just wrong to use script as module. It should be separated as a module if there're subroutines to be tested.
Comment 1 Basuke Suzuki 2021-10-17 12:34:20 PDT 
Created attachment 441543 [details]
PATCH
Comment 2 Basuke Suzuki 2021-10-17 12:42:38 PDT 
Created attachment 441545 [details]
PATCH
Comment 3 Basuke Suzuki 2021-10-17 12:45:47 PDT 
With this change, most of the warnings are removed when test webkitperl.

› Tools/Scripts/test-webkitperl
Tools/Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl ................................. ok
Tools/Scripts/webkitperl/auto-version_unittest/versionStampTests.pl ................................ ok
Tools/Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl ................ ok
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl ........ ok
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl ................. ok
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/filenameWithParentheses.pl ..................... ok
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl ....................... ok
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl ............................ ok
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl ............................... ok
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl ........................... ok
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl ........................... ok
Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl .................................. ok
Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl ................................. ok
Tools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl .................................... ok
Tools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl ..... ok
Tools/Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl .................... ok
Tools/Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl ................................. ok
Tools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl ...................................... ok
Tools/Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl ...................................... ok
Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl ............................................ ok
Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl ...................................... ok
Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffStartLine.pl ................................... ok
Tools/Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl ............................... ok
Tools/Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl ........................................ ok
Tools/Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl ................................... ok
Tools/Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl ........................................... ok
Tools/Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl ................................... ok
Tools/Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl ................................... ok
Tools/Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl ..................................... ok
Tools/Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl ................................ ok
Tools/Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl ............................... ok
Tools/Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl ................................... ok
Tools/Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl ............................................ ok
Tools/Scripts/webkitperl/VCSUtils_unittest/runCommand.pl ........................................... 1/3 Can't exec "/usr/bin/non-existent-command": No such file or directory at /Users/basuke/work/WebKit/Tools/Scripts/VCSUtils.pm line 2433.
Tools/Scripts/webkitperl/VCSUtils_unittest/runCommand.pl ........................................... ok
Tools/Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl ...................................... ok
Tools/Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl .......................... ok
Tools/Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl .................... ok
Tools/Scripts/webkitperl/webkitdirs_unittest/availableXcodeSDKS.pl ................................. ok
Tools/Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl .............. ok
Tools/Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl .. ok
Tools/Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl ................... ok
Tools/Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl ................... ok
Tools/Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl ....................................... ok
All tests successful.
Files=43, Tests=710, 11 wallclock secs ( 0.06 usr  0.05 sys +  2.45 cusr  0.74 csys =  3.30 CPU)
Result: PASS
Comment 4 Basuke Suzuki 2021-10-17 13:00:34 PDT 
Created attachment 441546 [details]
PATCH

Added missing copyright header
Comment 5 Basuke Suzuki 2021-10-18 09:39:58 PDT 
Created attachment 441617 [details]
Stop using keyword-like usage of subroutine
Comment 6 Basuke Suzuki 2021-10-18 10:30:06 PDT 
Created attachment 441622 [details]
Fix
Comment 7 Jonathan Bedard 2021-10-18 12:48:40 PDT 
Comment on attachment 441622 [details]
Fix

Should be fine on Apple Internal configurations too, these scripts already had webkitperl dependencies.
Comment 8 EWS 2021-10-18 14:17:09 PDT 
Committed r284399 (243175@main): <https://commits.webkit.org/243175@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441622 [details].
Comment 9 Radar WebKit Bug Importer 2021-10-18 14:18:19 PDT 
<rdar://problem/84387249>
Comment 10 Jonathan Bedard 2021-10-18 17:48:24 PDT 
Reverted r284399 for reason:

Breaks commit message generation

Committed r284419 (243187@main): <https://commits.webkit.org/243187@main>