Bug 231843 - [webkitscmpy] Filter approvers by status
Summary: [webkitscmpy] Filter approvers by status
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-15 16:11 PDT by Jonathan Bedard
Modified: 2021-10-19 12:39 PDT (History)
2 users (show)

See Also:

Attachments
Patch (9.10 KB, patch)
2021-10-15 16:30 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (10.33 KB, patch)
2021-10-19 11:23 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (10.32 KB, patch)
2021-10-19 11:26 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-10-15 16:11:31 PDT 
We should only list approvers that are reviewers, if a project even defines such a status.
Comment 1 Radar WebKit Bug Importer 2021-10-15 16:11:47 PDT 
<rdar://problem/84320934>
Comment 2 Jonathan Bedard 2021-10-15 16:30:29 PDT 
Created attachment 441452 [details]
Patch
Comment 3 Jonathan Bedard 2021-10-15 16:31:56 PDT 
https://github.com/WebKit/WebKit/pull/17
Comment 4 Jonathan Bedard 2021-10-19 11:23:36 PDT 
Created attachment 441761 [details]
Patch for landing
Comment 5 EWS 2021-10-19 11:24:49 PDT 
ChangeLog entry in Tools/ChangeLog contains OOPS!.
Comment 6 Jonathan Bedard 2021-10-19 11:26:12 PDT 
Created attachment 441762 [details]
Patch for landing
Comment 7 EWS 2021-10-19 12:39:34 PDT 
Committed r284479 (243238@main): <https://commits.webkit.org/243238@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441762 [details].