Bug 231791 - [iOS] Move styling of button-like controls into RenderTheme
Summary: [iOS] Move styling of button-like controls into RenderTheme
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks: 244233
  Show dependency tree / graph
 
Reported: 2021-10-14 18:51 PDT by Aditya Keerthi
Modified: 2022-08-23 00:06 PDT (History)
13 users (show)

See Also:

Attachments
Patch (48.43 KB, patch)
2021-10-14 19:25 PDT, Aditya Keerthi 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (48.43 KB, patch)
2021-10-14 19:46 PDT, Aditya Keerthi 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2021-10-14 18:51:06 PDT 
Button-like controls on iOS include buttons, <select>, and date inputs.

This change will enable support of accent-color for the aforementioned elements, and let "appearance: none" completely drop native styling.
Comment 1 Aditya Keerthi 2021-10-14 18:51:49 PDT 
rdar://84261773
Comment 2 Aditya Keerthi 2021-10-14 19:25:03 PDT 
Created attachment 441318 [details]
Patch
Comment 3 Aditya Keerthi 2021-10-14 19:46:32 PDT 
Created attachment 441322 [details]
Patch
Comment 4 Aditya Keerthi 2021-10-15 09:56:17 PDT 
Comment on attachment 441322 [details]
Patch

Apple Silicon failures are unrelated.
Comment 5 Aditya Keerthi 2021-10-15 15:34:12 PDT 
Comment on attachment 441322 [details]
Patch

This causes some WPT failures. Need to rethink how to move the styling over.