Bug 231769 - [AppleWin] Controls are not being rendered
Summary: [AppleWin] Controls are not being rendered
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-14 13:34 PDT by Per Arne Vollan
Modified: 2021-10-14 15:22 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.57 KB, patch)
2021-10-14 13:39 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-10-14 13:34:44 PDT 
Controls like checkboxes and buttons are not being rendered in AppleWin.
Comment 1 Per Arne Vollan 2021-10-14 13:35:18 PDT 
<rdar://problem/83670287>
Comment 2 Per Arne Vollan 2021-10-14 13:39:49 PDT 
Created attachment 441273 [details]
Patch
Comment 3 Fujii Hironori 2021-10-14 13:53:42 PDT 
Comment on attachment 441273 [details]
Patch

Sorry for the breakage. LGTM. But, I'm wondering why layout tests didn't catch the regression.
Comment 4 Per Arne Vollan 2021-10-14 14:42:25 PDT 
(In reply to Fujii Hironori from comment #3)
> Comment on attachment 441273 [details]
> Patch
> 
> Sorry for the breakage. LGTM. But, I'm wondering why layout tests didn't
> catch the regression.

Yes, that is a good point. I would expect there to be test coverage for this.

Thanks for reviewing!
Comment 5 EWS 2021-10-14 15:22:14 PDT 
Committed r284201 (243015@main): <https://commits.webkit.org/243015@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441273 [details].