WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
231722
Remove useless isConnected() check from HTMLDialogElement::close()
https://bugs.webkit.org/show_bug.cgi?id=231722
Summary
Remove useless isConnected() check from HTMLDialogElement::close()
Tim Nguyen (:ntim)
Reported
2021-10-13 22:33:02 PDT
https://webkit-search.igalia.com/webkit/source/Source/WebCore/html/HTMLDialogElement.cpp#98
There is already an early return in Element::focus when the element is not connected, so this check is redundant. See
comment 25
in
bug 227537
.
Attachments
Patch
(1.52 KB, patch)
2021-10-13 23:00 PDT
,
Tim Nguyen (:ntim)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1
2021-10-13 23:00:21 PDT
Created
attachment 441185
[details]
Patch
EWS
Comment 2
2021-10-14 00:04:12 PDT
Committed
r284149
(
242969@main
): <
https://commits.webkit.org/242969@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 441185
[details]
.
Radar WebKit Bug Importer
Comment 3
2021-10-14 00:05:15 PDT
<
rdar://problem/84236051
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug