Bug 231722 - Remove useless isConnected() check from HTMLDialogElement::close()
Summary: Remove useless isConnected() check from HTMLDialogElement::close()
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
Keywords: InRadar
Depends on:
Blocks: dialog-element 227537
  Show dependency treegraph
Reported: 2021-10-13 22:33 PDT by Tim Nguyen (:ntim)
Modified: 2021-10-14 00:05 PDT (History)
7 users (show)

See Also:

Patch (1.52 KB, patch)
2021-10-13 23:00 PDT, Tim Nguyen (:ntim)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-10-13 22:33:02 PDT

There is already an early return in Element::focus when the element is not connected, so this check is redundant.

See comment 25 in bug 227537.
Comment 1 Tim Nguyen (:ntim) 2021-10-13 23:00:21 PDT
Created attachment 441185 [details]
Comment 2 EWS 2021-10-14 00:04:12 PDT
Committed r284149 (242969@main): <https://commits.webkit.org/242969@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441185 [details].
Comment 3 Radar WebKit Bug Importer 2021-10-14 00:05:15 PDT