Bug 231626 - Upstream ANGLE: PrimitiveRestart tests fail due to incorrect draw commands
Summary: Upstream ANGLE: PrimitiveRestart tests fail due to incorrect draw commands
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kyle Piddington
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-12 14:56 PDT by Kyle Piddington
Modified: 2021-10-13 14:34 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.60 KB, patch)
2021-10-12 14:59 PDT, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Patch for landing (2.60 KB, patch)
2021-10-13 13:52 PDT, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Piddington 2021-10-12 14:56:54 PDT 
Upstream ANGLE: PrimitiveRestart tests fail due to incorrect draw commands
Comment 1 Kyle Piddington 2021-10-12 14:59:08 PDT 
Created attachment 440990 [details]
Patch
Comment 2 EWS Watchlist 2021-10-12 15:00:14 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kenneth Russell 2021-10-12 15:46:26 PDT 
Comment on attachment 440990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440990&action=review

Looks good - one comment. r+

> Source/ThirdParty/ANGLE/ChangeLog:10
> +        index buffer was aliased / reused.

Please mention "Cherry-pick from upstream anglebug.com/6535" or similar to keep the association clear.
Comment 4 Kyle Piddington 2021-10-13 13:52:35 PDT 
Created attachment 441132 [details]
Patch for landing
Comment 5 EWS 2021-10-13 14:33:08 PDT 
Committed r284125 (242945@main): <https://commits.webkit.org/242945@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441132 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-13 14:34:18 PDT 
<rdar://problem/84217315>