Bug 231587 - Invoke build scripts with python3 explicitly
Summary: Invoke build scripts with python3 explicitly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-12 10:00 PDT by Alexey Proskuryakov
Modified: 2021-10-13 09:52 PDT (History)
20 users (show)

See Also:


Attachments
proposed patch (49.89 KB, patch)
2021-10-12 10:55 PDT, Alexey Proskuryakov
jbedard: review+
ap: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2021-10-12 10:00:09 PDT
To use Python3 on macOS, we need to invoke it as python3.
Comment 1 Alexey Proskuryakov 2021-10-12 10:55:40 PDT
Created attachment 440958 [details]
proposed patch
Comment 2 Jonathan Bedard 2021-10-12 10:56:48 PDT
(In reply to Alexey Proskuryakov from comment #1)
> Created attachment 440958 [details]
> proposed patch

Looks reasonable, let's let EWS double-check we're not going to break any builds
Comment 3 EWS Watchlist 2021-10-12 10:56:53 PDT
This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 Michael Catanzaro 2021-10-12 10:59:35 PDT
Comment on attachment 440958 [details]
proposed patch

This is good for Linux too. Currently some distros have /usr/bin/python -> /usr/bin/python2 and others have /usr/bin/python -> /usr/bin/python3 and others just decided to delete /usr/bin/python altogether to avoid the confusion. Explicit is better than implicit....
Comment 5 Alexey Proskuryakov 2021-10-12 11:04:36 PDT
This doesn't touch ThirdParty yet, that will be a separate patch.
Comment 6 Alexey Proskuryakov 2021-10-13 09:43:44 PDT
Comment on attachment 440958 [details]
proposed patch

Windows build succeeded on retry, so must have been either an unrelated glitch, or a misconfigured bot. cq+
Comment 7 Alexey Proskuryakov 2021-10-13 09:44:16 PDT
Comment on attachment 440958 [details]
proposed patch

Actually no, I need to land this manually.
Comment 8 Alexey Proskuryakov 2021-10-13 09:52:30 PDT
Committed r284096.