Bug 231310 - [webkitscmpy] Library should own contributors.json loading
Summary: [webkitscmpy] Library should own contributors.json loading
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-06 10:45 PDT by Jonathan Bedard
Modified: 2021-10-07 17:09 PDT (History)
3 users (show)

See Also:

Attachments
Patch (11.56 KB, patch)
2021-10-06 13:27 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (12.88 KB, patch)
2021-10-07 16:08 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-10-06 10:45:33 PDT 
In preparation for integrating GitHub usernames, webkitscmpy should own the loading of contributors.json.
Comment 1 Radar WebKit Bug Importer 2021-10-06 10:46:11 PDT 
<rdar://problem/83941327>
Comment 2 Jonathan Bedard 2021-10-06 13:27:11 PDT 
Created attachment 440431 [details]
Patch
Comment 3 dewei_zhu 2021-10-07 14:52:37 PDT 
Comment on attachment 440431 [details]
Patch

r=me
Comment 4 Jonathan Bedard 2021-10-07 16:08:16 PDT 
Created attachment 440551 [details]
Patch for landing
Comment 5 EWS 2021-10-07 16:45:15 PDT 
Committed r283758 (242679@main): <https://commits.webkit.org/242679@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440551 [details].
Comment 6 Jonathan Bedard 2021-10-07 17:09:56 PDT 
Committed r283759 (242680@main): <https://commits.webkit.org/242680@main>