Bug 231026 - [macOS] Reduce sandbox telemetry
Summary: [macOS] Reduce sandbox telemetry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-30 09:57 PDT by Per Arne Vollan
Modified: 2021-09-30 12:53 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.56 KB, patch)
2021-09-30 10:20 PDT, Per Arne Vollan 		bfulgham: review+
Details | Formatted Diff | Diff
Patch (7.56 KB, patch)
2021-09-30 10:40 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-09-30 09:57:34 PDT 
Remove sandbox telemetry for resources that we already see are in use.
Comment 1 Per Arne Vollan 2021-09-30 09:58:21 PDT 
<rdar://83694937>
Comment 2 Per Arne Vollan 2021-09-30 10:20:42 PDT 
Created attachment 439753 [details]
Patch
Comment 3 Brent Fulgham 2021-09-30 10:34:41 PDT 
Comment on attachment 439753 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439753&action=review

r=me, but double-check that '/tmp' versus '/var' thing.

> Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:79
>      (literal "/var")

You remove '/tmp' here, but you give a specific rule for '/var' above. Which one is right?
Comment 4 Per Arne Vollan 2021-09-30 10:40:33 PDT 
Created attachment 439757 [details]
Patch
Comment 5 Per Arne Vollan 2021-09-30 10:41:38 PDT 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 439753 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=439753&action=review
> 
> r=me, but double-check that '/tmp' versus '/var' thing.
> 
> > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:79
> >      (literal "/var")
> 
> You remove '/tmp' here, but you give a specific rule for '/var' above. Which
> one is right?

Ah, good catch! I will fix.

Thanks for reviewing!
Comment 6 EWS 2021-09-30 12:53:34 PDT 
Committed r283323 (242348@main): <https://commits.webkit.org/242348@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439757 [details].