Bug 231004 - Replace the confusing isPinnedForScrollDelta() logic with code that uses BoxSide
Summary: Replace the confusing isPinnedForScrollDelta() logic with code that uses BoxSide
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-29 21:13 PDT by Simon Fraser (smfr)
Modified: 2021-09-30 14:00 PDT (History)
9 users (show)

See Also:

Attachments
Patch (40.22 KB, patch)
2021-09-29 21:15 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (39.62 KB, patch)
2021-09-30 10:58 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-09-29 21:13:03 PDT 
Replace the conusing isPinnedForScrollDelta() logic with code that uses BoxSide
Comment 1 Simon Fraser (smfr) 2021-09-29 21:15:39 PDT 
Created attachment 439699 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-09-30 10:58:51 PDT 
Created attachment 439760 [details]
Patch
Comment 3 Tim Horton 2021-09-30 11:01:31 PDT 
Comment on attachment 439760 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439760&action=review

> Source/WebCore/ChangeLog:3
> +        Replace the conusing isPinnedForScrollDelta() logic with code that uses BoxSide

"conusing"
Comment 4 Simon Fraser (smfr) 2021-09-30 13:59:07 PDT 
https://trac.webkit.org/changeset/283335/webkit
Comment 5 Radar WebKit Bug Importer 2021-09-30 14:00:23 PDT 
<rdar://problem/83736453>