Bug 230997 - [webkitscmpy] Contributors may be undefined
Summary: [webkitscmpy] Contributors may be undefined
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-29 16:10 PDT by Jonathan Bedard
Modified: 2021-09-29 18:25 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.64 KB, patch)
2021-09-29 16:12 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (3.02 KB, patch)
2021-09-29 16:55 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-09-29 16:10:56 PDT
It's possible that the callback that webkitscmpy is provided to generate the list of contributors returns None. In that event, we should retain the existing (most likely empty) list of contributors.
Comment 1 Radar WebKit Bug Importer 2021-09-29 16:11:09 PDT
<rdar://problem/83693400>
Comment 2 Jonathan Bedard 2021-09-29 16:12:13 PDT
Created attachment 439677 [details]
Patch
Comment 3 dewei_zhu 2021-09-29 16:14:13 PDT
Comment on attachment 439677 [details]
Patch

r=me
Comment 4 Jonathan Bedard 2021-09-29 16:55:45 PDT
Created attachment 439683 [details]
Patch for landing
Comment 5 EWS 2021-09-29 18:25:20 PDT
Committed r283292 (242317@main): <https://commits.webkit.org/242317@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439683 [details].