Bug 230989 - Add a default return value in convertToExceptionCode
Summary: Add a default return value in convertToExceptionCode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks: 231706
  Show dependency tree / graph
 
Reported: 2021-09-29 15:13 PDT by Sihui Liu
Modified: 2021-10-13 18:39 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2021-09-29 15:15 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (1.45 KB, patch)
2021-09-29 15:22 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2021-09-29 15:13:53 PDT 
...
Comment 1 Sihui Liu 2021-09-29 15:15:26 PDT 
Created attachment 439667 [details]
Patch
Comment 2 Chris Dumez 2021-09-29 15:16:57 PDT 
Comment on attachment 439667 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439667&action=review

> Source/WebKit/NetworkProcess/storage/FileSystemStorageError.h:53
>          return WebCore::ExceptionCode::UnknownError;

I think we usually:
break; 

instead of return here.

> Source/WebKit/NetworkProcess/storage/FileSystemStorageError.h:56
> +    ASSERT_NOT_REACHED();

And then not have ASSERT_NOT_REACHED() here.
Comment 3 Sihui Liu 2021-09-29 15:22:16 PDT 
Created attachment 439668 [details]
Patch
Comment 4 EWS 2021-09-29 16:32:02 PDT 
Committed r283280 (242307@main): <https://commits.webkit.org/242307@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439668 [details].
Comment 5 Radar WebKit Bug Importer 2021-09-29 16:33:52 PDT 
<rdar://problem/83694342>