Bug 230978 - Clean up PrivateClickMeasurement
Summary: Clean up PrivateClickMeasurement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-29 12:50 PDT by Alex Christensen
Modified: 2021-09-30 08:43 PDT (History)
8 users (show)

See Also:

Attachments
Patch (40.39 KB, patch)
2021-09-29 12:59 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (42.99 KB, patch)
2021-09-29 14:49 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-09-29 12:50:33 PDT 
Clean up PrivateClickMeasurement
Comment 1 Alex Christensen 2021-09-29 12:59:39 PDT 
Created attachment 439646 [details]
Patch
Comment 2 Kate Cheney 2021-09-29 13:34:27 PDT 
Comment on attachment 439646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439646&action=review

> Source/WebCore/loader/PrivateClickMeasurement.h:59
> +        static constexpr uint8_t MaxEntropy = 255;

This value is probably not needed anymore because you don't need to check validity of SourceID.

> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:2653
> +    return adoptNS([[UIEventAttribution alloc] initWithSourceIdentifier:measurement->sourceID().id destinationURL:destinationURL sourceDescription:nil purchaser:nil]).autorelease();

this doesn't seem correct.
Comment 3 Alex Christensen 2021-09-29 14:49:04 PDT 
Created attachment 439663 [details]
Patch
Comment 4 EWS 2021-09-30 08:42:38 PDT 
Committed r283313 (242338@main): <https://commits.webkit.org/242338@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439663 [details].
Comment 5 Radar WebKit Bug Importer 2021-09-30 08:43:16 PDT 
<rdar://problem/83721099>