Bug 230977 - REGRESSION (r282150): Missing background-color on inline box while hovering
Summary: REGRESSION (r282150): Missing background-color on inline box while hovering
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-29 12:18 PDT by zalan
Modified: 2021-09-30 08:26 PDT (History)
11 users (show)

See Also:

Attachments
Test case (143 bytes, text/html)
2021-09-29 12:18 PDT, zalan 		no flags Details
Patch (12.44 KB, patch)
2021-09-29 15:09 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.33 KB, patch)
2021-09-30 07:26 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-09-29 12:18:02 PDT 
Created attachment 439640 [details]
Test case

see attached test case
Comment 1 Radar WebKit Bug Importer 2021-09-29 12:18:27 PDT 
<rdar://problem/83682736>
Comment 2 zalan 2021-09-29 15:09:54 PDT 
Created attachment 439666 [details]
Patch
Comment 3 Antti Koivisto 2021-09-30 04:08:36 PDT 
Comment on attachment 439666 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439666&action=review

> Source/WebCore/rendering/RenderInline.cpp:194
> +            if (auto* container = LayoutIntegration::LineLayout::blockContainer(*this); container && shouldInvalidateLineLayoutPath)
>                  container->invalidateLineLayoutPath();

you could get the block via lineLayout->flow() too (and it doesn't need to be null tested).
Comment 4 zalan 2021-09-30 07:26:49 PDT 
Created attachment 439735 [details]
Patch
Comment 5 EWS 2021-09-30 08:26:29 PDT 
Committed r283312 (242337@main): <https://commits.webkit.org/242337@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439735 [details].