Bug 230939 - GraphicsContextGLAttributes::hasFenceSync should be a property of GraphicsContextGLOpenGL
Summary: GraphicsContextGLAttributes::hasFenceSync should be a property of GraphicsCon...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-29 00:59 PDT by Kimmo Kinnunen
Modified: 2021-09-30 05:48 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.23 KB, patch)
2021-09-29 01:02 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-09-29 00:59:35 PDT 
GraphicsContextGLAttributes::hasFenceSync should be a property of GraphicsContextGLOpenGL

hasFenceSync is just an internal bool of (Cocoa) GraphicsContextGLOpenGL
Comment 1 Kimmo Kinnunen 2021-09-29 01:02:48 PDT 
Created attachment 439577 [details]
Patch
Comment 2 Antti Koivisto 2021-09-29 03:34:53 PDT 
Comment on attachment 439577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439577&action=review

> Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h:797
> +    bool m_useFenceSyncForDisplayRateLimit = false;

I'd use the { } initialization syntax
Comment 3 EWS 2021-09-30 05:47:20 PDT 
Committed r283308 (242333@main): <https://commits.webkit.org/242333@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439577 [details].
Comment 4 Radar WebKit Bug Importer 2021-09-30 05:48:44 PDT 
<rdar://problem/83715396>