Bug 230920 - iOS simulator build should use PTHREAD_JIT_PERMISSIONS_API
Summary: iOS simulator build should use PTHREAD_JIT_PERMISSIONS_API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
: 228990 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-09-28 15:43 PDT by Yusuke Suzuki
Modified: 2021-09-29 00:25 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.52 KB, patch)
2021-09-28 15:45 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (1.51 KB, patch)
2021-09-28 15:49 PDT, Yusuke Suzuki 		fpizlo: review+
Details | Formatted Diff | Diff
Patch for landing (1.74 KB, patch)
2021-09-28 19:54 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-09-28 15:43:33 PDT 
iOS simulator build should use PTHREAD_JIT_PERMISSIONS_API
Comment 1 Yusuke Suzuki 2021-09-28 15:45:47 PDT 
Created attachment 439535 [details]
Patch
Comment 2 Yusuke Suzuki 2021-09-28 15:45:50 PDT 
<rdar://problem/77494871>
Comment 3 Yusuke Suzuki 2021-09-28 15:48:33 PDT 
Comment on attachment 439535 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439535&action=review

> Source/WTF/wtf/PlatformUse.h:331
> +    || (PLATFORM(IOS) && PLATFORM(IOS_SIMULATOR) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000)

PLATFORM(IOS) is not necessary. Removed.
Comment 4 Yusuke Suzuki 2021-09-28 15:49:38 PDT 
Created attachment 439536 [details]
Patch
Comment 5 Yusuke Suzuki 2021-09-28 16:07:23 PDT 
*** Bug 228990 has been marked as a duplicate of this bug. ***
Comment 6 Tim Horton 2021-09-28 16:43:15 PDT 
Do you perhaps want IOS_FAMILY_SIMULATOR? or is there something special about iOS *specifically*?
Comment 7 Yusuke Suzuki 2021-09-28 19:46:54 PDT 
(In reply to Tim Horton from comment #6)
> Do you perhaps want IOS_FAMILY_SIMULATOR? or is there something special
> about iOS *specifically*?

IOS_FAMILY_SIMULATOR is better, changed.
Comment 8 Yusuke Suzuki 2021-09-28 19:54:15 PDT 
Created attachment 439559 [details]
Patch for landing
Comment 9 Yusuke Suzuki 2021-09-28 23:23:40 PDT 
Committed r283211 (242253@main): <https://commits.webkit.org/242253@main>
Comment 10 Tim Horton 2021-09-28 23:41:52 PDT 
FWIW the final patch is a bit overkill, because we don't care about (or even successfully build on!) iOS < 14 or watchOS < 7 anymore. (I should have caught this when I said the last thing). Still, your patch is fine.
Comment 11 Yusuke Suzuki 2021-09-29 00:25:47 PDT 
(In reply to Tim Horton from comment #10)
> FWIW the final patch is a bit overkill, because we don't care about (or even
> successfully build on!) iOS < 14 or watchOS < 7 anymore. (I should have
> caught this when I said the last thing). Still, your patch is fine.

Ah! I see. Thanks!!