Bug 230914 - PCM: Change WebIDL attributes from all lowercase to camelcase to match spec and align with Attribution Reporting API
Summary: PCM: Change WebIDL attributes from all lowercase to camelcase to match spec a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-28 14:21 PDT by John Wilander
Modified: 2021-09-30 15:42 PDT (History)
9 users (show)

See Also:

Attachments
Patch (7.12 KB, patch)
2021-09-28 15:19 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2021-09-28 14:21:06 PDT 
We should change Private Click Measurement's anchor attributes from all lowercase to camelcase to match the spec and align with the Attribution Reporting API proposal.
Comment 1 Radar WebKit Bug Importer 2021-09-28 14:21:34 PDT 
<rdar://problem/83639923>
Comment 2 John Wilander 2021-09-28 15:19:09 PDT 
Created attachment 439529 [details]
Patch
Comment 3 Sam Sneddon [:gsnedders] 2021-09-30 11:40:26 PDT 
Non-reviewer r+.

That said, I've some slight concern about breakage here, though looking on GitHub doesn't immediately show up usage of the DOM APIs.
Comment 4 Brent Fulgham 2021-09-30 15:02:55 PDT 
Comment on attachment 439529 [details]
Patch

r=me
Comment 5 John Wilander 2021-09-30 15:14:20 PDT 
Comment on attachment 439529 [details]
Patch

Thanks, Sam and Brent!
Comment 6 EWS 2021-09-30 15:42:25 PDT 
Committed r283342 (242358@main): <https://commits.webkit.org/242358@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439529 [details].