Bug 230790 - Font palette names have to start with two hyphens
Summary: Font palette names have to start with two hyphens
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 230446
  Show dependency tree / graph
 
Reported: 2021-09-25 03:14 PDT by Myles C. Maxfield
Modified: 2021-09-29 08:41 PDT (History)
10 users (show)

See Also:

Attachments
Patch (40.81 KB, patch)
2021-09-25 03:18 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (40.88 KB, patch)
2021-09-25 03:37 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (51.44 KB, patch)
2021-09-27 23:05 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (51.46 KB, patch)
2021-09-28 01:28 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (50.84 KB, patch)
2021-09-28 14:14 PDT, Myles C. Maxfield 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-09-25 03:14:03 PDT 
Font palette names have to start with two hyphens
Comment 1 Myles C. Maxfield 2021-09-25 03:18:34 PDT 
Created attachment 439253 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-09-25 03:19:07 PDT 
<rdar://problem/83530013>
Comment 3 EWS Watchlist 2021-09-25 03:20:00 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 4 Myles C. Maxfield 2021-09-25 03:37:59 PDT 
Created attachment 439255 [details]
Patch
Comment 5 Myles C. Maxfield 2021-09-27 12:55:41 PDT 
Comment on attachment 439255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439255&action=review

> Source/WebCore/css/parser/CSSParserImpl.cpp:662
> +    auto name = CSSPropertyParserHelpers::consumeDashedCustomIdent(prelude);

This is not a good name.
Comment 6 Myles C. Maxfield 2021-09-27 23:05:06 PDT 
Created attachment 439435 [details]
Patch
Comment 7 Myles C. Maxfield 2021-09-28 01:28:11 PDT 
Created attachment 439443 [details]
Patch
Comment 8 Myles C. Maxfield 2021-09-28 14:14:25 PDT 
Created attachment 439515 [details]
Patch
Comment 9 Myles C. Maxfield 2021-09-29 08:41:04 PDT 
Committed r283221 (242263@main): <https://commits.webkit.org/242263@main>