Bug 230610 - REGRESSION(r282082): [GTK] Tests timeout when using xvfb after r282082
Summary: REGRESSION(r282082): [GTK] Tests timeout when using xvfb after r282082
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2021-09-22 04:14 PDT by Carlos Garcia Campos
Modified: 2021-09-22 04:30 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.79 KB, patch)
2021-09-22 04:15 PDT, Carlos Garcia Campos
pnormand: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-09-22 04:14:22 PDT
r282082 changed the way xvfb is spawned by providing a PIPE for stdout and stderr instead of redirecting to /dev/null. The problem is that stderr is only read in case of execution failure, so when nothing fails we end up filling the buffer that is never read. We can try to find a better solution to show the stderr output in error messages, but for now we can revert that part to redirect stderr to /dev/null to make the tests work again.
Comment 1 Carlos Garcia Campos 2021-09-22 04:15:55 PDT
Created attachment 438941 [details]
Patch
Comment 2 Carlos Garcia Campos 2021-09-22 04:29:09 PDT
Committed r282870 (241999@main): <https://commits.webkit.org/241999@main>
Comment 3 Radar WebKit Bug Importer 2021-09-22 04:30:17 PDT
<rdar://problem/83392739>