Bug 230549 - [webkitcorepy] Fail to parse python required version when there's a space between operator and version
Summary: [webkitcorepy] Fail to parse python required version when there's a space bet...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 230551
  Show dependency tree / graph
 
Reported: 2021-09-21 04:49 PDT by Carlos Garcia Campos
Modified: 2021-09-21 07:51 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.34 KB, patch)
2021-09-21 04:51 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-09-21 04:49:19 PDT 
This happened to me with pytest-asyncio, data-requires-python contains ">= 3.5", but Version::matches() is using the == operator because the regular expression fails to get the operator.
Comment 1 Carlos Garcia Campos 2021-09-21 04:51:45 PDT 
Created attachment 438806 [details]
Patch
Comment 2 Jonathan Bedard 2021-09-21 07:47:17 PDT 
I'm going to cq+ this, I'm concerned we're going to have bots start to hit it
Comment 3 EWS 2021-09-21 07:50:59 PDT 
Committed r282813 (241944@main): <https://commits.webkit.org/241944@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438806 [details].
Comment 4 Radar WebKit Bug Importer 2021-09-21 07:51:15 PDT 
<rdar://problem/83351855>