Bug 230456 - [Flatpak SDK] Add bwrap and xdg-dbus-proxy
Summary: [Flatpak SDK] Add bwrap and xdg-dbus-proxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-19 03:46 PDT by Philippe Normand
Modified: 2021-09-29 07:39 PDT (History)
4 users (show)

See Also:

Attachments
[fast-cq] Patch (2.76 KB, patch)
2021-09-19 03:54 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2021-09-19 03:46:12 PDT 
SSIA
Comment 1 Philippe Normand 2021-09-19 03:54:15 PDT 
Created attachment 438589 [details]
[fast-cq] Patch
Comment 2 Patrick Griffis 2021-09-23 13:53:41 PDT 
Why are these being added? `bwrap` can't actually run inside of `flatpak`.
Comment 3 Philippe Normand 2021-09-23 13:59:39 PDT 
Comment on attachment 438589 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438589&action=review

> Tools/buildstream/ChangeLog:8
> +        These are needed in order to enable the Bubblewrap launcher in WPE/GTK at build time.

^^
Comment 4 Philippe Normand 2021-09-29 07:23:06 PDT 
Even though the bwrap code path won't be used at runtime, I think enabling this at build time would still be good, so the corresponding code remains tested on EWS and other build bots.
Comment 5 EWS 2021-09-29 07:38:58 PDT 
Committed r283215 (242257@main): <https://commits.webkit.org/242257@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438589 [details].
Comment 6 Radar WebKit Bug Importer 2021-09-29 07:39:16 PDT 
<rdar://problem/83670437>